Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: correctly clean up server process after e2e tests #1666

Merged
merged 3 commits into from
Nov 26, 2019
Merged

ci: correctly clean up server process after e2e tests #1666

merged 3 commits into from
Nov 26, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

using KILL does not actually kill all child processes of yarn start

refs #1559

@a-b-r-o-w-n
use TERM signal to kill server on exit
8c1c3f4 
using KILL does not actually kill all child processes of `yarn start`
@a-b-r-o-w-n a-b-r-o-w-n merged commit f492bef into microsoft:master Nov 26, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix-e2e-script branch November 26, 2019 22:48
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-b-r-o-w-n @cwhitten